Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: remove deprecated WithServiceConfig DialOption #6800

Merged
merged 3 commits into from
Nov 15, 2023
Merged

client: remove deprecated WithServiceConfig DialOption #6800

merged 3 commits into from
Nov 15, 2023

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Nov 15, 2023

RELEASE NOTES:

  • client: remove deprecated WithServiceConfig DialOption

@dfawley dfawley added the Type: API Change Breaking API changes (experimental APIs only!) label Nov 15, 2023
@dfawley dfawley added this to the 1.61 Release milestone Nov 15, 2023
@dfawley dfawley requested a review from arvindbr8 November 15, 2023 18:38
@arvindbr8 arvindbr8 assigned dfawley and unassigned arvindbr8 Nov 15, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 15, 2023 •
edited
Loading

Codecov Report

Merging #6800 (6574ea4) into master (42fdcc4) will decrease coverage by 0.05%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6800      +/-   ##
==========================================
- Coverage   83.54%   83.49%   -0.05%     
==========================================
  Files         285      285              
  Lines       30925    30893      -32     
==========================================
- Hits        25836    25795      -41     
- Misses       4016     4025       +9     
  Partials     1073     1073
Files Coverage Δ
clientconn.go 93.15% <ø> (+0.47%) ⬆️
dialoptions.go 88.74% <ø> (-0.20%) ⬇️

... and 18 files with indirect coverage changes

@dfawley dfawley merged commit 232054a into grpc:master Nov 15, 2023
14 checks passed
@dfawley dfawley deleted the withsvccfg branch December 4, 2023 22:17
dfawley added a commit to dfawley/grpc-go that referenced this pull request Dec 7, 2023
@dfawley
client: remove deprecated WithServiceConfig DialOption (grpc#6800)
e0445c7
@dfawley dfawley modified the milestones: 1.61 Release, 1.60 Release Dec 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arvindbr8 arvindbr8 arvindbr8 approved these changes

Assignees

@dfawley dfawley

Labels
Type: API Change Breaking API changes (experimental APIs only!)
Projects
None yet
Milestone
1.60 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@dfawley @arvindbr8