Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: rework resolver and balancer wrappers to avoid deadlock #6804

Merged
merged 21 commits into from
Dec 5, 2023

review comments

7ae0904
Select commit
Loading
Failed to load commit list.
Merged

client: rework resolver and balancer wrappers to avoid deadlock #6804

review comments
7ae0904
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Nov 30, 2023 in 1s

80.21% of diff hit (target 83.40%)

View this Pull Request on Codecov

80.21% of diff hit (target 83.40%)

Annotations

Check warning on line 101 in balancer_wrapper.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

balancer_wrapper.go#L100-L101 

Added lines #L100 - L101 were not covered by tests

Check warning on line 105 in balancer_wrapper.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

balancer_wrapper.go#L105 

Added line #L105 was not covered by tests

Check warning on line 130 in balancer_wrapper.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

balancer_wrapper.go#L129-L130 

Added lines #L129 - L130 were not covered by tests

Check warning on line 149 in balancer_wrapper.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

balancer_wrapper.go#L148-L149 

Added lines #L148 - L149 were not covered by tests

Check warning on line 200 in balancer_wrapper.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

balancer_wrapper.go#L199-L200 

Added lines #L199 - L200 were not covered by tests

Check warning on line 212 in balancer_wrapper.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

balancer_wrapper.go#L211-L212 

Added lines #L211 - L212 were not covered by tests

Check warning on line 253 in balancer_wrapper.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

balancer_wrapper.go#L253 

Added line #L253 was not covered by tests

Check warning on line 276 in balancer_wrapper.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

balancer_wrapper.go#L276 

Added line #L276 was not covered by tests

Check warning on line 356 in clientconn.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

clientconn.go#L355-L356 

Added lines #L355 - L356 were not covered by tests

Check warning on line 662 in clientconn.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

clientconn.go#L660-L662 

Added lines #L660 - L662 were not covered by tests

Check warning on line 834 in clientconn.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

clientconn.go#L833-L834 

Added lines #L833 - L834 were not covered by tests

Check warning on line 136 in internal/idle/idle.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/idle/idle.go#L136 

Added line #L136 was not covered by tests

Check warning on line 151 in internal/idle/idle.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/idle/idle.go#L151 

Added line #L151 was not covered by tests

Check warning on line 193 in internal/idle/idle.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/idle/idle.go#L188-L193 

Added lines #L188 - L193 were not covered by tests

Check warning on line 206 in internal/idle/idle.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/idle/idle.go#L206 

Added line #L206 was not covered by tests

Check warning on line 69 in resolver_wrapper.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

resolver_wrapper.go#L68-L69 

Added lines #L68 - L69 were not covered by tests

Check warning on line 161 in resolver_wrapper.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

resolver_wrapper.go#L150-L161 

Added lines #L150 - L161 were not covered by tests
View more details on Codecov