completely delete WatchListener and WatchRouteConfig APIs #6849
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6849 +/- ##
==========================================
+ Coverage 83.43% 83.54% +0.10%
==========================================
Files 286 286
Lines 30801 30781 -20
==========================================
+ Hits 25699 25716 +17
+ Misses 4028 3999 -29
+ Partials 1074 1066 -8
|
| // This route configuration watcher registers two | ||
| // more watches from the OnUpdate callback of the original resource for which it was created. |
There was a problem hiding this comment.
Wrap to 80 chars please :).
There was a problem hiding this comment.
"registers two watches corresponding to the names passed in at creation time on a valid update"?
| // Create a route configuration watcher that registers two more watches from | ||
| // the OnUpdate callback: | ||
| // - one for the same resource name as this watch, which would be | ||
| // satisfied from xdsClient cache | ||
| // - the other for a different resource name, which would be | ||
| // satisfied from the server |
There was a problem hiding this comment.
I don't understand what this is testing (I feel like a certain xDS resource can't trigger another watch for the same xDS resource) but since this is already in the codebase I'm fine leaving it.
There was a problem hiding this comment.
I feel like a certain xDS resource can't trigger another watch for the same xDS resource
Wouldn't happen in practice. But this test wants to ensure that even if that happens, things work fine.
This PR gets rid of the old
WatchListenerandWatchRouteConfigAPIs. This should be the last PR to call time on the old APIs.#resource-agnostic-xdsclient-api
RELEASE NOTES: none