Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/xds: Use different import path for gRPC Messages #6933

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

zasweq
Copy link
Contributor

@zasweq zasweq commented Jan 22, 2024

This PR correctly differentiates messages and services as, they come in distinct imports.

RELEASE NOTES: N/A

@zasweq zasweq requested a review from dfawley January 22, 2024 23:07
@zasweq zasweq added the Type: Meta Github repo, process, etc label Jan 22, 2024
@zasweq zasweq added this to the 1.61 Release milestone Jan 22, 2024
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Merging #6933 (dff94e4) into master (e96f521) will decrease coverage by 0.20%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6933      +/-   ##
==========================================
- Coverage   83.83%   83.63%   -0.20%     
==========================================
  Files         287      287              
  Lines       30931    30931              
==========================================
- Hits        25931    25870      -61     
- Misses       3947     3991      +44     
- Partials     1053     1070      +17     

see 16 files with indirect coverage changes

@zasweq zasweq changed the title Fix import test/xds: Use different import path for gRPC Messages Jan 22, 2024
@zasweq zasweq merged commit 52e2363 into grpc:master Jan 23, 2024
14 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Meta Github repo, process, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants