status: modify TestStatus_ErrorDetails_Fail to replace protoimpl package #6953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6953 +/- ##
==========================================
- Coverage 83.71% 83.69% -0.02%
==========================================
Files 287 287
Lines 30926 30929 +3
==========================================
- Hits 25889 25886 -3
- Misses 3972 3979 +7
+ Partials 1065 1064 -1
|
dfawley
approved these changes
Jan 31, 2024
| got := tc.s.Details() | ||
| if !cmp.Equal(got, tc.i, cmp.Comparer(proto.Equal), cmp.Comparer(equalError)) { | ||
| t.Errorf("(%v).Details() = %+v, want %+v", str(tc.s), got, tc.i) | ||
| details := tc.s.Details() |
There was a problem hiding this comment.
You should first ensure len(details) == len(tc.want) here or it could panic.
There was a problem hiding this comment.
that's right! thanks for catching that
status/status_test.go
Outdated
| t.Errorf("(%v).Details() = %+v, want %+v", str(tc.s), got, tc.i) | ||
| details := tc.s.Details() | ||
| for i, d := range details { | ||
| // s.Deatils can either contain an error or a proto message. We |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The protoimpl package is being currently used in a test (which got introduced in #6919). But this package cannot be accessed directly in google3, hence we need a different way of testing the case.
RELEASE NOTES: none