grpc: add clientconn.CanonicalTarget() to return the canonical target string #7006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvindbr8
added
the
Type: Behavior Change
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7006 +/- ##
==========================================
+ Coverage 82.21% 82.51% +0.30%
==========================================
Files 296 296
Lines 31473 31467 -6
==========================================
+ Hits 25874 25964 +90
+ Misses 4531 4448 -83
+ Partials 1068 1055 -13
|
arvindbr8
changed the title
dfawley
approved these changes
Feb 28, 2024
clientconn.go
Outdated
Comment on lines
887
to
901
| // | ||
| // # Experimental | ||
| // | ||
| // Notice: This API is EXPERIMENTAL and may be changed or removed in a | ||
| // later release. | ||
| func (cc *ClientConn) Target() string { | ||
| return cc.target | ||
| } | ||
|
|
||
| // CanonicalTarget returns the canonical target string of the ClientConn. | ||
| // | ||
| // # Experimental | ||
| // | ||
| // Notice: This API is EXPERIMENTAL and may be changed or removed in a later | ||
| // release. |
There was a problem hiding this comment.
Let's delete these experimental labels. Target() will always return the string passed to Dial and CanonicalTarget will always return the scheme://[authority]/[endpoint].
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change does 3 things:
CanonicalTarget()API that returns canonical target stringRELEASE NOTES: