Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick #6997 to 1.62.x release branch #7018

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

arvindbr8
Copy link
Member

@arvindbr8 arvindbr8 commented Mar 4, 2024

RELEASE NOTES:

  • xdsclient: lookup VirtualHost config from RDS response using the dataplane authority from the dial target instead of using LDS resource name

@arvindbr8 arvindbr8 requested a review from dfawley March 4, 2024 21:12
@arvindbr8 arvindbr8 added this to the 1.62 Release milestone Mar 4, 2024
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Merging #7018 (1e7a128) into v1.62.x (7c4b553) will increase coverage by 0.10%.
The diff coverage is 80.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           v1.62.x    #7018      +/-   ##
===========================================
+ Coverage    82.28%   82.39%   +0.10%     
===========================================
  Files          296      296              
  Lines        31452    31449       -3     
===========================================
+ Hits         25879    25911      +32     
+ Misses        4505     4476      -29     
+ Partials      1068     1062       -6     
Files Coverage Δ
clientconn.go 92.89% <ø> (+1.79%) ⬆️
resolver/resolver.go 94.44% <ø> (ø)
resolver_wrapper.go 85.18% <100.00%> (+0.13%) ⬆️
xds/internal/resolver/xds_resolver.go 79.61% <75.00%> (+0.68%) ⬆️

... and 16 files with indirect coverage changes

@arvindbr8 arvindbr8 merged commit 9d981b0 into grpc:v1.62.x Mar 4, 2024
14 checks passed
@arvindbr8 arvindbr8 changed the title cherry-pick #6997 to 1.62.x release branch (#6979) cherry-pick #6997 to 1.62.x release branch Mar 4, 2024
@arvindbr8 arvindbr8 deleted the cherry_pick_6997 branch May 30, 2024 00:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants