Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: Update features/encryption/README.md file #7045

Merged
merged 9 commits into from
Mar 22, 2024

Conversation

AntiBargu
Copy link
Contributor

@AntiBargu AntiBargu commented Mar 19, 2024

When I read the above document, I found several small mistakes. In order to prevent misunderstandings among newcomers while reading. I fix those mistakes and add instructions for key files in the mTLS example.

RELEASE NOTES: none

Copy link

linux-foundation-easycla bot commented Mar 19, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Merging #7045 (288248b) into master (dadbbfa) will increase coverage by 0.04%.
Report is 7 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7045      +/-   ##
==========================================
+ Coverage   82.45%   82.49%   +0.04%     
==========================================
  Files         299      300       +1     
  Lines       31314    31357      +43     
==========================================
+ Hits        25819    25869      +50     
+ Misses       4435     4430       -5     
+ Partials     1060     1058       -2     

see 29 files with indirect coverage changes

@zasweq zasweq self-requested a review March 20, 2024 03:27
@zasweq zasweq self-assigned this Mar 20, 2024
Copy link
Contributor

@zasweq zasweq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM outside minor nits.

examples/features/encryption/README.md Outdated Show resolved Hide resolved
examples/features/encryption/README.md Outdated Show resolved Hide resolved
examples/features/encryption/README.md Outdated Show resolved Hide resolved
@zasweq zasweq requested a review from dfawley March 21, 2024 20:45
@zasweq zasweq assigned dfawley and unassigned zasweq Mar 21, 2024
@zasweq
Copy link
Contributor

zasweq commented Mar 21, 2024

Passing to Doug for a second pass.

examples/features/encryption/README.md Outdated Show resolved Hide resolved
examples/features/encryption/README.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@AntiBargu AntiBargu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed

@dfawley dfawley added the Type: Documentation Documentation or examples label Mar 22, 2024
@dfawley dfawley added this to the 1.64 Release milestone Mar 22, 2024
@dfawley dfawley assigned zasweq and unassigned AntiBargu Mar 22, 2024
@dfawley
Copy link
Member

dfawley commented Mar 22, 2024

Assigning to @zasweq to re-review and merge if OK.

@zasweq zasweq merged commit b78c0eb into grpc:master Mar 22, 2024
14 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Documentation Documentation or examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants