-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
examples: Update features/encryption/README.md file #7045
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7045 +/- ##
==========================================
+ Coverage 82.45% 82.49% +0.04%
==========================================
Files 299 300 +1
Lines 31314 31357 +43
==========================================
+ Hits 25819 25869 +50
+ Misses 4435 4430 -5
+ Partials 1060 1058 -2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM outside minor nits.
Passing to Doug for a second pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review completed
Assigning to @zasweq to re-review and merge if OK. |
When I read the above document, I found several small mistakes. In order to prevent misunderstandings among newcomers while reading. I fix those mistakes and add instructions for key files in the mTLS example.
RELEASE NOTES: none