*: fix regenerate.sh #7139
Merged
*: fix regenerate.sh #7139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
reviewed
Apr 17, 2024
scripts/vet.sh
Outdated
| @@ -119,7 +119,6 @@ grep "(SA1019)" "${SC_OUT}" | not grep -Fv 'XXXXX PleaseIgnoreUnused | |||
| XXXXX Protobuf related deprecation errors: | |||
| "github.com/golang/protobuf | |||
| .pb.go: | |||
| grpc_testing_not_regenerate | |||
There was a problem hiding this comment.
Staticcheck is staying within the module?
Ugh, should we be running it for every go.mod then?
There was a problem hiding this comment.
That's right. Let's track this here #7141
dfawley
approved these changes
Apr 18, 2024
| @@ -26,6 +26,6 @@ import ( | |||
| "google.golang.org/grpc/internal/channelz" | |||
| ) | |||
|
|
|||
| func sockoptToProto(skopts *channelz.SocketOptionData) []*channelzpb.SocketOption { | |||
| func sockoptToProto(_ *channelz.SocketOptionData) []*channelzpb.SocketOption { | |||
There was a problem hiding this comment.
No need to change this here but there is even an even more simplified version:
func sockoptToProto(*channelz.SocketOptionData) []*channelzpb.SocketOption {
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vet.shwas failing in macOS. The logger defined in channelz/internal/protoconv package was not used when build on non_linux machines, which caused staticcheck to output this:also fixes the go_package for grpc_testing_not_regenerate proto
RELEASE NOTES: none