Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: improve grammar in the interceptor example #7163

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

arjan-bal
Copy link
Contributor

RELEASE NOTES: none

@aranjans
Copy link
Contributor

LGTM!

@aranjans aranjans added the Type: Meta Github repo, process, etc label Apr 23, 2024
@aranjans aranjans added this to the 1.64 Release milestone Apr 23, 2024
@dfawley dfawley assigned arjan-bal and unassigned aranjans Apr 23, 2024
@arjan-bal arjan-bal force-pushed the fix-interceptor-typo branch from 7352349 to 5850271 Compare April 24, 2024 06:00
@arjan-bal arjan-bal changed the title Cleanup: fix a typo in interceptor feature example readme Cleanup: Improve grammar in the interceptor tutorial Apr 24, 2024
@arjan-bal arjan-bal changed the title Cleanup: Improve grammar in the interceptor tutorial Cleanup: Improve grammar in the interceptor tutorial Apr 24, 2024
@arjan-bal arjan-bal force-pushed the fix-interceptor-typo branch 2 times, most recently from 1397692 to fc52d22 Compare April 24, 2024 06:10
@arjan-bal arjan-bal requested a review from dfawley April 24, 2024 06:12
@arjan-bal arjan-bal assigned dfawley and unassigned arjan-bal Apr 24, 2024
Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanups!

examples/features/interceptor/README.md Outdated Show resolved Hide resolved
examples/features/interceptor/README.md Outdated Show resolved Hide resolved
examples/features/interceptor/README.md Outdated Show resolved Hide resolved
examples/features/interceptor/README.md Outdated Show resolved Hide resolved
examples/features/interceptor/README.md Outdated Show resolved Hide resolved
examples/features/interceptor/README.md Outdated Show resolved Hide resolved
examples/features/interceptor/README.md Outdated Show resolved Hide resolved
@dfawley dfawley assigned arjan-bal and unassigned dfawley Apr 24, 2024
@dfawley dfawley added Type: Documentation Documentation or examples and removed Type: Meta Github repo, process, etc labels Apr 24, 2024
@arjan-bal arjan-bal force-pushed the fix-interceptor-typo branch from fc52d22 to f153bf5 Compare April 25, 2024 06:57
@arjan-bal arjan-bal assigned dfawley and unassigned arjan-bal Apr 25, 2024
@arjan-bal
Copy link
Contributor Author

@dfawley I've addressed the comments. PTAL and help merge the PR if it looks good.

@dfawley
Copy link
Member

dfawley commented Apr 25, 2024

@arjan-bal please avoid force-pushes whenever possible.

If you can't avoid a force push (i.e. because of conflicting changes on master), then please:

  1. do NOT do squashes - use separate commits for updates. we squash when we merge the PR.
  2. wait until as late as possible to do the force push

Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@dfawley dfawley changed the title Cleanup: Improve grammar in the interceptor tutorial examples: improve grammar in the interceptor example Apr 25, 2024
@dfawley dfawley merged commit 750e1de into grpc:master Apr 25, 2024
12 checks passed
@arjan-bal
Copy link
Contributor Author

@arjan-bal please avoid force-pushes whenever possible.

If you can't avoid a force push (i.e. because of conflicting changes on master), then please:

  1. do NOT do squashes - use separate commits for updates. we squash when we merge the PR.
  2. wait until as late as possible to do the force push

Acknowledged. I was squashing commits to keep the history clean. I didn't know that the maintainers do the same before merging. Will keep the usage of destructive commands to a minimum.

@arjan-bal arjan-bal deleted the fix-interceptor-typo branch April 25, 2024 16:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Documentation Documentation or examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants