-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
examples: improve grammar in the interceptor example #7163
Conversation
LGTM! |
7352349
to
5850271
Compare
1397692
to
fc52d22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the cleanups!
fc52d22
to
f153bf5
Compare
@dfawley I've addressed the comments. PTAL and help merge the PR if it looks good. |
@arjan-bal please avoid force-pushes whenever possible. If you can't avoid a force push (i.e. because of conflicting changes on master), then please:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Acknowledged. I was squashing commits to keep the history clean. I didn't know that the maintainers do the same before merging. Will keep the usage of destructive commands to a minimum. |
RELEASE NOTES: none