-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
protoc-gen-go-grpc: copy service comment to interfaces #7243
Conversation
I think there are two tests failed, should modify test case? I am so sorry, i can't know it, please maintainer to answer me and i modify immediately. Thanks! |
I have modified the comment. I don’t know what I need to do next. If there is anything else I need to do, please explain it to me. Thank you. @purnesh42H |
@silves-xiang could you provide the two tests which are failing? I only see Mergeable check failing |
The failed test has been fixed. The reason is that the pb.go generated by the proto file of the automated test was not updated in time, causing the automated test to be considered a failure. |
@purnesh42H At the beginning, I only modified the program code and not the automatically generated pb.go file, which resulted in an automatic failure. I have regenerated the pb.go file generated by proto in time. |
@purnesh42H Hello, I just modified it, but I don’t know if it is in line with what you meant. If it is wrong, please correct me. I will modify immediately, Thanks! |
8636196
to
467a091
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7243 +/- ##
==========================================
- Coverage 81.24% 80.55% -0.69%
==========================================
Files 345 349 +4
Lines 33941 34032 +91
==========================================
- Hits 27574 27415 -159
- Misses 5202 5428 +226
- Partials 1165 1189 +24 |
72c4cbb
to
cf5b4f5
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Let @dfawley review it once
4f6d19f
to
dd41c8f
Compare
@purnesh42H @dfawley It has been processed, please check it. If there is any problem, please tell me and I will modify it immediately and resubmit it.Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for the contribution
This PR to fix Bug #7233 , copy proto comment to pb.go file
I am very interested in this project. If there are any problems with the code I mentioned, please point it out and I will modify it immediately and submit it again. Thanks!
This PR adds an internal only (exported, but can only set through internal/) LateApplyDialOption type. This will be used in CSM Observability.
RELEASE NOTES: N/A