Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/protoc-gen-go-grpc: remove replace and skip test that requires it for now #7451

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Jul 29, 2024

RELEASE NOTES: none

@dfawley dfawley added this to the 1.66 Release milestone Jul 29, 2024
@dfawley dfawley requested a review from arjan-bal July 29, 2024 16:34
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.36%. Comparing base (3eb0145) to head (3450374).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7451      +/-   ##
==========================================
- Coverage   81.57%   81.36%   -0.22%     
==========================================
  Files         354      354              
  Lines       27076    27076              
==========================================
- Hits        22088    22031      -57     
- Misses       3798     3834      +36     
- Partials     1190     1211      +21     

see 24 files with indirect coverage changes

@arjan-bal arjan-bal assigned dfawley and unassigned arjan-bal Jul 29, 2024
@dfawley dfawley merged commit 245323c into grpc:master Jul 29, 2024
13 checks passed
printchard pushed a commit to printchard/grpc-go that referenced this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants