Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transport/grpchttp2: revert #7477 usage of mem package #7485

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

printchard
Copy link
Contributor

Revert #7477 in order to pursue a implementation with standard types

RELEASE NOTES: none

@printchard printchard requested a review from easwars August 6, 2024 22:27
@arvindbr8 arvindbr8 changed the title transport/grpchttp2: revert #7477 transport/grpchttp2: revert #7477 usage of mem package Aug 6, 2024
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 81.37%. Comparing base (e6b6318) to head (7b02e5f).

Files Patch % Lines
internal/transport/grpchttp2/framer.go 0.00% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7485      +/-   ##
==========================================
- Coverage   81.59%   81.37%   -0.23%     
==========================================
  Files         357      357              
  Lines       27224    27242      +18     
==========================================
- Hits        22213    22167      -46     
- Misses       3807     3851      +44     
- Partials     1204     1224      +20     
Files Coverage Δ
internal/transport/grpchttp2/framer.go 0.00% <0.00%> (ø)

... and 22 files with indirect coverage changes

@printchard printchard added the Type: Internal Cleanup Refactors, etc label Aug 6, 2024
@printchard printchard added this to the 1.66 Release milestone Aug 6, 2024
@easwars easwars assigned arvindbr8 and unassigned easwars Aug 7, 2024
@arvindbr8 arvindbr8 merged commit 1490d60 into grpc:master Aug 7, 2024
13 checks passed
infovivek2020 pushed a commit to infovivek2020/grpc-go that referenced this pull request Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants