benchmark: wire in new gzip compressor #7486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change, the benchmarks did not actually include executions with the new gzip compressor from the `encoding/gzip` package. This adds the option to run the suite with said new compressor and adds it to the "all" suite as well.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7486 +/- ##
==========================================
+ Coverage 81.40% 81.58% +0.18%
==========================================
Files 357 357
Lines 27243 27224 -19
==========================================
+ Hits 22176 22211 +35
+ Misses 3850 3809 -41
+ Partials 1217 1204 -13 |
dfawley
reviewed
Aug 7, 2024
dfawley
changed the title
dfawley
approved these changes
Aug 13, 2024
easwars
approved these changes
Aug 13, 2024
infovivek2020
pushed a commit
to infovivek2020/grpc-go
that referenced
this pull request
Aug 18, 2024
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, the benchmarks did not actually include executions with the new gzip compressor from the
encoding/gzippackage. This adds the option to run the suite with said new compressor and adds it to the "all" suite as well.RELEASE NOTES: none