-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster_resolver: wait for child policy configuration update inline #7490
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aranjans
force-pushed
the
aranjans_cluster_resolver
branch
from
August 7, 2024 06:59
0867977
to
f001b07
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7490 +/- ##
==========================================
+ Coverage 81.40% 81.60% +0.20%
==========================================
Files 357 358 +1
Lines 27243 27351 +108
==========================================
+ Hits 22176 22320 +144
+ Misses 3850 3822 -28
+ Partials 1217 1209 -8
|
purnesh42H
changed the title
cluster_resolver: wait for child policy configuration update inline
clusterresolver: wait for child policy configuration update inline
Aug 7, 2024
purnesh42H
reviewed
Aug 7, 2024
purnesh42H
changed the title
clusterresolver: wait for child policy configuration update inline
cluster_resolver: wait for child policy configuration update inline
Aug 7, 2024
purnesh42H
reviewed
Aug 10, 2024
xds/internal/balancer/clusterresolver/e2e_test/balancer_test.go
Outdated
Show resolved
Hide resolved
purnesh42H
reviewed
Aug 10, 2024
Closing this PR for now as we are waiting for this task to close first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#5469 recommends an audit of existing LB policies to ensure that they update their pickers synchronously upon receipt of a configuration update.
cluster_resolver
neither does update its picker synchronously nor wait for the child policy configuration update inline.What does this PR do?
This PR ensures that every time configuration update is triggered, it waits for child policy configuration update inline.
RELEASE NOTES: