Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster_resolver: wait for child policy configuration update inline #7490

Closed
wants to merge 3 commits into from

Conversation

aranjans
Copy link
Contributor

@aranjans aranjans commented Aug 7, 2024

Problem

#5469 recommends an audit of existing LB policies to ensure that they update their pickers synchronously upon receipt of a configuration update. cluster_resolver neither does update its picker synchronously nor wait for the child policy configuration update inline.

What does this PR do?

This PR ensures that every time configuration update is triggered, it waits for child policy configuration update inline.

RELEASE NOTES:

  • cluster_resolver: wait for child policy configuration update inline

@aranjans aranjans added this to the 1.66 Release milestone Aug 7, 2024
@aranjans aranjans force-pushed the aranjans_cluster_resolver branch from 0867977 to f001b07 Compare August 7, 2024 06:59
@aranjans aranjans requested a review from purnesh42H August 7, 2024 07:00
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.60%. Comparing base (e524655) to head (c7e6556).
Report is 30 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7490      +/-   ##
==========================================
+ Coverage   81.40%   81.60%   +0.20%     
==========================================
  Files         357      358       +1     
  Lines       27243    27351     +108     
==========================================
+ Hits        22176    22320     +144     
+ Misses       3850     3822      -28     
+ Partials     1217     1209       -8     
Files Coverage Δ
...ternal/balancer/clusterresolver/clusterresolver.go 71.51% <100.00%> (+1.02%) ⬆️

... and 35 files with indirect coverage changes

@purnesh42H purnesh42H changed the title cluster_resolver: wait for child policy configuration update inline clusterresolver: wait for child policy configuration update inline Aug 7, 2024
@purnesh42H purnesh42H assigned aranjans and unassigned purnesh42H Aug 7, 2024
@purnesh42H purnesh42H changed the title clusterresolver: wait for child policy configuration update inline cluster_resolver: wait for child policy configuration update inline Aug 7, 2024
@aranjans aranjans assigned aranjans and unassigned aranjans Aug 7, 2024
@aranjans aranjans assigned purnesh42H and unassigned aranjans Aug 8, 2024
@arjan-bal arjan-bal modified the milestones: 1.66 Release, 1.67 Release Aug 16, 2024
@aranjans
Copy link
Contributor Author

Closing this PR for now as we are waiting for this task to close first

@aranjans aranjans closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants