Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latency: don't wrap when all the latencies are zero #7506

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Aug 13, 2024

When using "local" mode, the latency package adds some significant allocations into our benchmarks and doesn't even attempt to do anything.

RELEASE NOTES: none

@dfawley dfawley added the Type: Performance Performance improvements (CPU, network, memory, etc) label Aug 13, 2024
@dfawley dfawley added this to the 1.66 Release milestone Aug 13, 2024
@dfawley dfawley requested a review from easwars August 13, 2024 21:36
@easwars easwars assigned dfawley and unassigned easwars Aug 13, 2024
@dfawley dfawley merged commit eece43b into grpc:master Aug 13, 2024
11 checks passed
@dfawley dfawley deleted the latencylocalbench branch August 13, 2024 21:57
infovivek2020 pushed a commit to infovivek2020/grpc-go that referenced this pull request Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Performance Performance improvements (CPU, network, memory, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants