Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

balancer/rls: Fix RLS Cache metrics #7511

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Conversation

zasweq
Copy link
Contributor

@zasweq zasweq commented Aug 14, 2024

This PR fixes the RLS Cache metrics. I accidentally deleted the wrong recording point in my final commit on #7495.

RELEASE NOTES: N/A

@zasweq zasweq requested a review from easwars August 14, 2024 21:17
@zasweq zasweq added this to the 1.66 Release milestone Aug 14, 2024
@easwars easwars assigned zasweq and unassigned easwars Aug 14, 2024
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@9706bf8). Learn more about missing BASE report.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #7511   +/-   ##
=========================================
  Coverage          ?   81.66%           
=========================================
  Files             ?      359           
  Lines             ?    27531           
  Branches          ?        0           
=========================================
  Hits              ?    22484           
  Misses            ?     3824           
  Partials          ?     1223           
Files Coverage Δ
balancer/rls/cache.go 88.98% <100.00%> (ø)

@zasweq zasweq merged commit 7ec3fd2 into grpc:master Aug 14, 2024
13 checks passed
infovivek2020 pushed a commit to infovivek2020/grpc-go that referenced this pull request Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants