-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
balancer/wrr: prefer calling Equal() method of time.Time #7529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7529 +/- ##
==========================================
- Coverage 82.07% 81.83% -0.25%
==========================================
Files 360 360
Lines 27533 27508 -25
==========================================
- Hits 22599 22510 -89
- Misses 3759 3799 +40
- Partials 1175 1199 +24
|
aranjans
changed the title
balancer/wrr: prefer calling Equal() method of time.Time over direct …
balancer/wrr: prefer calling Equal() method of time.Time
Aug 18, 2024
easwars
reviewed
Aug 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few more occurrences:
easwars@minetop: grpc-go$ grep -r "==.*time.Time{}" *
balancer/weightedroundrobin/balancer.go: if w.nonEmptySince == (time.Time{}) {
balancer/weightedroundrobin/balancer.go: if w.lastUpdated == (time.Time{}) {
balancer/weightedroundrobin/balancer.go: if blackoutPeriod != 0 && (w.nonEmptySince == (time.Time{}) || now.Sub(w.nonEmptySince) < blackoutPeriod) {
test/config_selector_test.go: if wantDeadline == (time.Time{}) {
easwars
approved these changes
Aug 21, 2024
purnesh42H
approved these changes
Aug 26, 2024
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefer calling Equal() method of time.Time over direct comparision.
RELEASE NOTES: none