stats/otel: upgrade grpc version that contains the experimental/stats package #7545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xperimental/stats
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7545 +/- ##
==========================================
- Coverage 81.93% 81.84% -0.10%
==========================================
Files 362 361 -1
Lines 27831 27825 -6
==========================================
- Hits 22803 22773 -30
- Misses 3832 3854 +22
- Partials 1196 1198 +2 |
dfawley
reviewed
Aug 28, 2024
| @@ -12,7 +12,7 @@ require ( | |||
| go.opentelemetry.io/otel/metric v1.28.0 | |||
| go.opentelemetry.io/otel/sdk v1.28.0 | |||
| go.opentelemetry.io/otel/sdk/metric v1.28.0 | |||
| google.golang.org/grpc v1.65.0 | |||
There was a problem hiding this comment.
Done, 1.66.0 was not available at the time.
arvindbr8
changed the title
dfawley
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building stats/otel was broken on its own because this package depends on
grpc/experimental/statswhich is not released yet. Our tests passed because of the replace directive magic.RELEASE NOTES: none