-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.*: Use strings.ReplaceAll(.....)
#7554
Conversation
Signed-off-by: bytetigers <bytetiger@icloud.com>
The committers listed above are authorized under a signed CLA. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7554 +/- ##
==========================================
- Coverage 81.82% 81.77% -0.06%
==========================================
Files 362 362
Lines 27834 27834
==========================================
- Hits 22776 22761 -15
- Misses 3850 3858 +8
- Partials 1208 1215 +7
|
strings.Replace(....., -1)
with strings.ReplaceAll(.....)
strings.Replace(....., -1)
with strings.ReplaceAll(.....)
strings.ReplaceAll(.....)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@arvindbr8 adding you for one more review |
@bytetigers -- Thanks for the PR. I've updated the PR description to talk about the change. Also |
strings.ReplaceAll(.....)
strings.ReplaceAll(.....)
string.ReplaceAll()
is equivalent tostring.Replace()
with a limit of -1RELEASE NOTES: none