Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.*: revive from unused_parameters #7577

Merged
merged 2 commits into from
Aug 30, 2024

update vet

8860c9c
Select commit
Loading
Failed to load commit list.
Merged

.*: revive from unused_parameters #7577

update vet
8860c9c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 30, 2024 in 0s

81.89% (+0.12%) compared to 845f62c

View this Pull Request on Codecov

81.89% (+0.12%) compared to 845f62c

Details

Codecov Report

Attention: Patch coverage is 76.81159% with 16 lines in your changes missing coverage. Please review.

Project coverage is 81.89%. Comparing base (845f62c) to head (8860c9c).

Files with missing lines Patch % Lines
credentials/oauth/oauth.go 0.00% 3 Missing ⚠️
mem/buffers.go 0.00% 2 Missing ⚠️
profiling/service/service.go 0.00% 2 Missing ⚠️
rpc_util.go 88.23% 2 Missing ⚠️
balancer/endpointsharding/endpointsharding.go 0.00% 1 Missing ⚠️
balancer_wrapper.go 0.00% 1 Missing ⚠️
channelz/service/service.go 85.71% 1 Missing ⚠️
credentials/alts/internal/testutil/testutil.go 50.00% 1 Missing ⚠️
credentials/tls/certprovider/store.go 0.00% 1 Missing ⚠️
grpclog/internal/logger.go 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7577      +/-   ##
==========================================
+ Coverage   81.76%   81.89%   +0.12%     
==========================================
  Files         361      361              
  Lines       27825    27825              
==========================================
+ Hits        22752    22787      +35     
+ Misses       3866     3849      -17     
+ Partials     1207     1189      -18
Files with missing lines Coverage Δ
balancer/base/balancer.go 87.03% <100.00%> (+1.85%) ⬆️
balancer/pickfirst/pickfirst.go 83.73% <100.00%> (ø)
balancer/weightedroundrobin/balancer.go 80.51% <100.00%> (ø)
credentials/alts/internal/handshaker/handshaker.go 80.00% <100.00%> (+5.00%) ⬆️
credentials/insecure/insecure.go 81.81% <100.00%> (ø)
credentials/local/local.go 73.52% <100.00%> (ø)
credentials/xds/xds.go 88.88% <100.00%> (ø)
health/server.go 95.52% <100.00%> (ø)
internal/binarylog/method_logger.go 88.49% <100.00%> (ø)
internal/resolver/passthrough/passthrough.go 100.00% <100.00%> (ø)
... and 25 more

... and 17 files with indirect coverage changes

View more details on Codecov