Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.*: replace grpc.Dial with grpc.NewClient in test files #7609

Closed

error message change

505fd73
Select commit
Loading
Failed to load commit list.
Closed

.*: replace grpc.Dial with grpc.NewClient in test files #7609

error message change
505fd73
Select commit
Loading
Failed to load commit list.
Mergeable / Mergeable failed Sep 17, 2024 in 53s

1/3 Fail(s): MILESTONE

Status: FAIL

    Here are some stats of the run:
    3 validations were ran.
    2 PASSED
    1 FAILED

Details

✔️ Validator: LABEL

  • ✔️ label must include '^Type:'
    Input : Type: Documentation,Area: Documentation
    Settings : {"must_include":{"regex":"^Type:"}}

✔️ Validator: DESCRIPTION

  • ✔️ description must include '^RELEASE NOTES:\s([Nn][Oo][Nn][Ee]|[Nn]/[Aa]|\n(*|-)\s.+)$'**
    Input : Partially address: #7049

Update tests where only direct replacement is enough to replace grpc.Dial with grpc.NewClient in test files

RELEASE NOTES: None

   Settings : ```{"must_include":{"regex":"^RELEASE NOTES:\\s*([Nn][Oo][Nn][Ee]|[Nn]/[Aa]|\\n(\\*|-)\\s*.+)$","regex_flag":"m"}}```

❌ Validator: MILESTONE

  • milestone does not include "Release$"
    Input :
    Settings : {"must_include":{"regex":"Release$"}}