Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds: return all ServerConfig dial options together #7680

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

eshitachandwani
Copy link
Member

@eshitachandwani eshitachandwani commented Sep 30, 2024

Fixes : #7661

Added a single DialOptions() method that returns a slice of all dial options for the type ServerConfig instead of individual methods to get all dial options.

RELEASE NOTES: None

@eshitachandwani eshitachandwani added this to the 1.68 Release milestone Sep 30, 2024
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.82%. Comparing base (7aee163) to head (7d3bc83).
Report is 15 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7680      +/-   ##
==========================================
- Coverage   82.00%   81.82%   -0.18%     
==========================================
  Files         361      361              
  Lines       27825    27820       -5     
==========================================
- Hits        22817    22763      -54     
- Misses       3825     3857      +32     
- Partials     1183     1200      +17     
Files with missing lines Coverage Δ
internal/xds/bootstrap/bootstrap.go 71.56% <100.00%> (+0.08%) ⬆️
xds/internal/xdsclient/transport/transport.go 94.02% <100.00%> (-0.08%) ⬇️

... and 30 files with indirect coverage changes

@easwars easwars self-assigned this Oct 1, 2024
internal/xds/bootstrap/bootstrap.go Outdated Show resolved Hide resolved
xds/internal/xdsclient/transport/transport.go Outdated Show resolved Hide resolved
xds/internal/xdsclient/transport/transport_test.go Outdated Show resolved Hide resolved
@easwars easwars assigned eshitachandwani and unassigned easwars Oct 1, 2024
@easwars
Copy link
Contributor

easwars commented Oct 1, 2024

Also, there is a typo in the PR title and we don't need release notes for this change. This is a completely internal API and does not make sense to our users.

@eshitachandwani eshitachandwani changed the title xds: return all ServerCofig dial options together xds: return all ServerConfig dial options together Oct 4, 2024
@easwars easwars assigned eshitachandwani and unassigned easwars Oct 4, 2024
@easwars easwars merged commit f17ea7d into grpc:master Oct 8, 2024
14 checks passed
janardhanvissa pushed a commit to janardhanvissa/grpc-go that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xds: change ServerConfig type to have a single method to return all configured dial options
3 participants