-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xds: return all ServerConfig dial options together #7680
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7680 +/- ##
==========================================
- Coverage 82.00% 81.82% -0.18%
==========================================
Files 361 361
Lines 27825 27820 -5
==========================================
- Hits 22817 22763 -54
- Misses 3825 3857 +32
- Partials 1183 1200 +17
|
easwars
reviewed
Oct 1, 2024
Also, there is a typo in the PR title and we don't need release notes for this change. This is a completely internal API and does not make sense to our users. |
eshitachandwani
changed the title
xds: return all ServerCofig dial options together
xds: return all ServerConfig dial options together
Oct 4, 2024
easwars
approved these changes
Oct 4, 2024
janardhanvissa
pushed a commit
to janardhanvissa/grpc-go
that referenced
this pull request
Oct 15, 2024
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes : #7661
Added a single
DialOptions()
method that returns a slice of all dial options for the typeServerConfig
instead of individual methods to get all dial options.RELEASE NOTES: None