Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds: return all ServerConfig dial options together #7718

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

eshitachandwani
Copy link
Member

@eshitachandwani eshitachandwani commented Oct 9, 2024

Fixes : #7661

  • Added a single DialOptions() method that returns a slice of all dial options for the type ServerConfig instead of individual methods to get all dial options.
  • Removed the TestNewWithDialerFromCredentialsBundle test since it was already being tested here in TestClientCustomDialerFromCredentialsBundle (b8ee37d/test/xds/xds_client_custom_dialer_test.go#L83C10-L83C53)

RELEASE NOTES: None

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.85%. Comparing base (b8ee37d) to head (fa8d5c1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7718      +/-   ##
==========================================
+ Coverage   81.84%   81.85%   +0.01%     
==========================================
  Files         361      361              
  Lines       27827    27825       -2     
==========================================
+ Hits        22775    22777       +2     
- Misses       3850     3852       +2     
+ Partials     1202     1196       -6     
Files with missing lines Coverage Δ
internal/xds/bootstrap/bootstrap.go 71.56% <100.00%> (+0.08%) ⬆️
xds/internal/xdsclient/transport/transport.go 92.43% <100.00%> (-0.88%) ⬇️

... and 18 files with indirect coverage changes

@easwars easwars added Type: Internal Cleanup Refactors, etc and removed Type: Bug labels Oct 9, 2024
@easwars easwars merged commit 4115c21 into grpc:master Oct 9, 2024
14 checks passed
janardhanvissa pushed a commit to janardhanvissa/grpc-go that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xds: change ServerConfig type to have a single method to return all configured dial options
2 participants