Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testutils: change ListenerWrapper to push the most recently accepted connection #7772

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Oct 23, 2024

#a71-xds-fallback
#xdsclient-refactor
Addresses #6902

Some e2e style tests cannot control the backoff behavior for reconnecting after a failed connection. So, making the ListenerWrapper push the most recently accepted connection on the channel, makes it easier for these tests.

RELEASE NOTES: none

@easwars easwars requested a review from zasweq October 23, 2024 18:17
@easwars easwars added this to the 1.68 Release milestone Oct 23, 2024
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.37%. Comparing base (8212cf0) to head (8579907).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7772      +/-   ##
==========================================
- Coverage   81.40%   81.37%   -0.04%     
==========================================
  Files         368      368              
  Lines       36768    36768              
==========================================
- Hits        29932    29919      -13     
- Misses       5607     5617      +10     
- Partials     1229     1232       +3     
Files with missing lines Coverage Δ
internal/testutils/wrappers.go 87.50% <100.00%> (ø)

... and 18 files with indirect coverage changes

@zasweq zasweq assigned easwars and unassigned zasweq Oct 25, 2024
@easwars easwars merged commit a82315c into grpc:master Oct 25, 2024
14 of 15 checks passed
@easwars easwars deleted the listener_wrapper_accept branch October 25, 2024 18:33
misvivek pushed a commit to misvivek/grpc-go that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants