credentials: Support ALTSPerRPCCreds in DefaultCredentialsOptions #7775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7775 +/- ##
==========================================
- Coverage 81.32% 81.20% -0.13%
==========================================
Files 368 368
Lines 36779 36799 +20
==========================================
- Hits 29912 29883 -29
- Misses 5635 5666 +31
- Partials 1232 1250 +18
|
|
@dfawley This is for the ALTS token design. The Java equivalent is grpc/grpc-java#11634. Could you help review this PR? |
dfawley
approved these changes
Oct 25, 2024
credentials/google/google.go
Outdated
| @@ -39,6 +39,9 @@ var logger = grpclog.Component("credentials") | |||
| type DefaultCredentialsOptions struct { | |||
| // PerRPCCreds is a per RPC credentials that is passed to a bundle. | |||
| PerRPCCreds credentials.PerRPCCredentials | |||
| // ALTSRPCCreds is a per RPC credentials that, if specified, will supercede | |||
There was a problem hiding this comment.
Thanks for the catch. Fixed.
rockspore
changed the title
misvivek
pushed a commit
to misvivek/grpc-go
that referenced
this pull request
Nov 7, 2024
…pc#7775) * Replace the gRFC pull request with the permanent link. * add ALTSPerRPCCreds in DefaultCredentialsOptions to support channel aware RPC creds * go vet * address comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RELEASE NOTES: none