Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

balancer/weightedroundrobin: Switch Weighted Round Robin to use pick first instead of SubConns #7826

Merged
merged 5 commits into from
Nov 23, 2024

Responded to Doug's comments

d026beb
Select commit
Loading
Failed to load commit list.
Merged

balancer/weightedroundrobin: Switch Weighted Round Robin to use pick first instead of SubConns #7826

Responded to Doug's comments
d026beb
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 22, 2024 in 0s

81.82% (-0.03%) compared to d2c1aae

View this Pull Request on Codecov

81.82% (-0.03%) compared to d2c1aae

Details

Codecov Report

Attention: Patch coverage is 85.38813% with 32 lines in your changes missing coverage. Please review.

Project coverage is 81.82%. Comparing base (d2c1aae) to head (d026beb).
Report is 24 commits behind head on master.

Files with missing lines Patch % Lines
balancer/weightedroundrobin/balancer.go 85.92% 22 Missing and 7 partials ⚠️
balancer/endpointsharding/endpointsharding.go 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7826      +/-   ##
==========================================
- Coverage   81.84%   81.82%   -0.03%     
==========================================
  Files         373      375       +2     
  Lines       37845    37984     +139     
==========================================
+ Hits        30976    31082     +106     
- Misses       5578     5590      +12     
- Partials     1291     1312      +21     
Files with missing lines Coverage Δ
balancer/weightedroundrobin/scheduler.go 96.20% <100.00%> (-3.80%) ⬇️
balancer/endpointsharding/endpointsharding.go 79.65% <66.66%> (+16.62%) ⬆️
balancer/weightedroundrobin/balancer.go 83.47% <85.92%> (+4.01%) ⬆️

... and 48 files with indirect coverage changes

---- 🚨 Try these New Features: