Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Remove Go minor version from go.mods #7831

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

arjan-bal
Copy link
Contributor

@arjan-bal arjan-bal commented Nov 12, 2024

The Go minor versions were added when bumping the go major version from 1.21 to 1.22 by running go get go@1.22 && go mod tidy. Specifying the minor version is not necessary unless a dependency specifies a go minor version. This PR removes the minor version from all but one go.mod file which is used for testing.

Why

As mentioned in this thread, grpc-go being a library should not specify a patch version.

RELEASE NOTES:

  • Relax minimum Go version requirement from go1.22.7 to go1.22.

@arjan-bal arjan-bal added the Type: Dependencies Updating/adding/removing dependencies label Nov 12, 2024
@arjan-bal arjan-bal added this to the 1.69 Release milestone Nov 12, 2024
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.01%. Comparing base (e2b98f9) to head (a47a96c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7831      +/-   ##
==========================================
+ Coverage   81.91%   82.01%   +0.09%     
==========================================
  Files         374      374              
  Lines       37930    37930              
==========================================
+ Hits        31071    31107      +36     
+ Misses       5566     5539      -27     
+ Partials     1293     1284       -9     

see 20 files with indirect coverage changes

@arjan-bal arjan-bal requested a review from dfawley November 12, 2024 17:50
@arjan-bal arjan-bal changed the title deps: Remove unnecessary go patch version from go.mods deps: Remove Go minor version from go.mods Nov 12, 2024
Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up.

@arjan-bal arjan-bal merged commit 3db86e2 into grpc:master Nov 12, 2024
15 checks passed
@arjan-bal arjan-bal deleted the remove-patch-version branch November 13, 2024 06:32
@matthewhartstonge
Copy link

matthewhartstonge commented Nov 13, 2024

Adding this to the conversation over at: golang/go#65847

Tracking issues related to the changes to the go/toolchain directive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Dependencies Updating/adding/removing dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants