-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: Remove Go minor version from go.mods #7831
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7831 +/- ##
==========================================
+ Coverage 81.91% 82.01% +0.09%
==========================================
Files 374 374
Lines 37930 37930
==========================================
+ Hits 31071 31107 +36
+ Misses 5566 5539 -27
+ Partials 1293 1284 -9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning this up.
Adding this to the conversation over at: golang/go#65847 Tracking issues related to the changes to the go/toolchain directive |
The Go minor versions were added when bumping the go major version from 1.21 to 1.22 by running
go get go@1.22 && go mod tidy
. Specifying the minor version is not necessary unless a dependency specifies a go minor version. This PR removes the minor version from all but one go.mod file which is used for testing.Why
As mentioned in this thread, grpc-go being a library should not specify a patch version.
RELEASE NOTES: