-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stream: add jitter to retry backoff in accordance with gRFC A6 #7869
Conversation
Update the delay calculation to reflect the updated gRFC
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7869 +/- ##
==========================================
- Coverage 82.04% 82.00% -0.05%
==========================================
Files 375 375
Lines 37984 37984
==========================================
- Hits 31165 31148 -17
- Misses 5532 5540 +8
- Partials 1287 1296 +9
|
@isgj Thanks for raising the PR. Can you add an end to end test to verify the same? |
Would be good if we could update the README of examples for retry feature. |
@aranjans can you point to the README and the example file that needs updating? |
The README already points to the right gRFC https://github.com/grpc/grpc-go/blob/master/examples/features/retry/README.md?plain=1#L7
I see the tests at https://github.com/grpc/grpc-go/blob/master/test/retry_test.go. |
@isgj Yes that's the correct reference to README.
Overall this change LGTM, adding the @easwars as second reviewer to take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR!
Update the delay calculation to reflect the updated gRFC
Address #7514
RELEASE NOTES: