balancer/pickfirst: replace grpc.Dial with grpc.NewClient in tests #7879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7879 +/- ##
==========================================
- Coverage 82.04% 81.90% -0.15%
==========================================
Files 377 377
Lines 38117 38117
==========================================
- Hits 31272 31218 -54
- Misses 5548 5590 +42
- Partials 1297 1309 +12 |
arjan-bal
approved these changes
Dec 3, 2024
| if err != nil { | ||
| t.Fatalf("Failed to dial server at %q: %v", lis.Addr(), err) | ||
| t.Fatalf("Failed to create new client server at %q: %v", lis.Addr(), err) |
There was a problem hiding this comment.
Please fix the grammar. We can also remove the server address because NewClient doesn't create a transport immediately, so it unlikely that the server had anything to do with the failure.
t.Fatalf("Failed to create new client: %v", err)
arjan-bal
changed the title
hanut19
force-pushed
the
replacing-dial-with-newclient
branch
from
7b949f9 to
bef686e
Compare
purnesh42H
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace grpc.Dial with grpc.NewClient in test files
Addresses: #7049
RELEASE NOTES: None