Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts/gen-deps: filter out grpc modules #7890

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Dec 2, 2024

Any of grpc's modules should be fine to use anywhere, unless they pull in unwanted dependencies from outside grpc. Since the deps are generated with all transitive dependencies, simply filtering out all packages under google.golang.org/grpc should tell us what we want and not have red Xs on the presubmit statuses when nothing external changes.

RELEASE NOTES: none

@dfawley dfawley requested a review from easwars December 2, 2024 19:00
@dfawley dfawley assigned dfawley and easwars and unassigned dfawley Dec 2, 2024
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.06%. Comparing base (4c07bca) to head (9b6cf7b).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7890      +/-   ##
==========================================
+ Coverage   81.84%   82.06%   +0.21%     
==========================================
  Files         377      377              
  Lines       38120    38112       -8     
==========================================
+ Hits        31201    31276      +75     
+ Misses       5603     5537      -66     
+ Partials     1316     1299      -17     

see 27 files with indirect coverage changes

@easwars easwars assigned dfawley and unassigned easwars Dec 2, 2024
@dfawley dfawley added the Area: Testing Includes tests and testing utilities that we have for unit and e2e tests within our repo. label Dec 2, 2024
@dfawley dfawley added this to the 1.69 Release milestone Dec 2, 2024
@dfawley dfawley added Type: Testing and removed Area: Testing Includes tests and testing utilities that we have for unit and e2e tests within our repo. labels Dec 2, 2024
@dfawley dfawley merged commit 17d08f7 into grpc:master Dec 2, 2024
14 of 15 checks passed
@dfawley dfawley deleted the deps2 branch December 2, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants