Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change version to 1.70.0-dev #7903

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

purnesh42H
Copy link
Contributor

@purnesh42H purnesh42H commented Dec 5, 2024

RELEASE NOTES: None

@purnesh42H purnesh42H added the Type: Meta Github repo, process, etc label Dec 5, 2024
@purnesh42H purnesh42H added this to the 1.69 Release milestone Dec 5, 2024
@purnesh42H purnesh42H requested a review from arjan-bal December 5, 2024 08:24
@purnesh42H purnesh42H modified the milestones: 1.69 Release, 1.70 Release Dec 5, 2024
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.08%. Comparing base (317271b) to head (44748ae).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7903      +/-   ##
==========================================
- Coverage   82.13%   82.08%   -0.06%     
==========================================
  Files         377      377              
  Lines       38179    38179              
==========================================
- Hits        31360    31340      -20     
- Misses       5525     5546      +21     
+ Partials     1294     1293       -1     

see 21 files with indirect coverage changes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of extra commits in the PR that need to be removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed. looks like my fork was not updated. Updated that as well.

@arjan-bal arjan-bal assigned purnesh42H and unassigned arjan-bal Dec 5, 2024
@purnesh42H purnesh42H force-pushed the release_version_1.70.0-dev branch from b750b88 to 9604d9a Compare December 5, 2024 08:50
@purnesh42H purnesh42H requested a review from arjan-bal December 5, 2024 08:52
@purnesh42H purnesh42H assigned arjan-bal and unassigned purnesh42H Dec 5, 2024
@purnesh42H purnesh42H force-pushed the release_version_1.70.0-dev branch 2 times, most recently from 44748ae to 9604d9a Compare December 5, 2024 09:01
@arjan-bal arjan-bal assigned purnesh42H and unassigned arjan-bal Dec 5, 2024
@purnesh42H purnesh42H merged commit d7286fb into grpc:master Dec 5, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Meta Github repo, process, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants