Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpcs: update WithContextDialer documentation to include using passthrough resolver #7916

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

purnesh42H
Copy link
Contributor

Fixes: #7856

RELEASE NOTES: None

@purnesh42H purnesh42H added the Type: Documentation Documentation or examples label Dec 10, 2024
@purnesh42H purnesh42H added this to the 1.70 Release milestone Dec 10, 2024
@purnesh42H purnesh42H requested a review from dfawley December 10, 2024 09:30
@purnesh42H
Copy link
Contributor Author

@dfawley could you ptal?

dialoptions.go Outdated Show resolved Hide resolved
@purnesh42H purnesh42H assigned purnesh42H and unassigned dfawley Dec 14, 2024
purnesh42H and others added 2 commits December 15, 2024 23:15
Co-authored-by: Doug Fawley <dfawley@google.com>
@purnesh42H purnesh42H requested a review from dfawley December 15, 2024 17:48
@purnesh42H purnesh42H assigned dfawley and unassigned purnesh42H Dec 15, 2024
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.14%. Comparing base (66ba4b2) to head (91fe068).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7916      +/-   ##
==========================================
+ Coverage   82.04%   82.14%   +0.09%     
==========================================
  Files         377      379       +2     
  Lines       38180    38230      +50     
==========================================
+ Hits        31326    31404      +78     
+ Misses       5551     5530      -21     
+ Partials     1303     1296       -7     
Files with missing lines Coverage Δ
dialoptions.go 88.97% <ø> (ø)

... and 32 files with indirect coverage changes

@dfawley
Copy link
Member

dfawley commented Dec 16, 2024

Thanks!

@dfawley dfawley assigned purnesh42H and unassigned dfawley Dec 16, 2024
@purnesh42H purnesh42H merged commit e8055ea into grpc:master Dec 17, 2024
15 checks passed
purnesh42H added a commit to purnesh42H/grpc-go that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation Documentation or examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

passthrough scheme not documented
2 participants