Flip default for RLS on XDS being enabled to true. #10248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
added
the
TODO:backport
temawi
reviewed
Jun 5, 2023
| @@ -172,7 +172,6 @@ public class XdsClientImplDataTest { | |||
| @Before | |||
| public void setUp() { | |||
| originalEnableRouteLookup = XdsResourceType.enableRouteLookup; | |||
| assertThat(originalEnableRouteLookup).isFalse(); | |||
There was a problem hiding this comment.
Would you want to assert that it's true?
There was a problem hiding this comment.
It seemed to me to just be clutter to check the default. It made some sense when it was a protective flag, but checking for true on every flag we've ever introduced seems messy to me.
temawi
approved these changes
Jun 5, 2023
larry-safran
added a commit
to larry-safran/grpc-java
that referenced
this pull request
Jun 5, 2023
larry-safran
added a commit
that referenced
this pull request
Jun 6, 2023
ejona86
removed
the
TODO:backport
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by Eric in thread: https://chat.google.com/room/AAAAbkw9L3c/HzqpO0OaYlQ