core: Deprecate ForwardingChannelBuilder #10587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiitk
force-pushed
the
deprecate-fwd-channel-builder
branch
3 times, most recently
from
a726446 to
121922d
Compare
ejona86
reviewed
Oct 6, 2023
| @@ -26,7 +26,7 @@ | |||
| * using ALTS if applicable and using TLS as fallback. | |||
| */ | |||
| public final class ComputeEngineChannelBuilder | |||
| extends ForwardingChannelBuilder<ComputeEngineChannelBuilder> { | |||
| extends ForwardingChannelBuilder2<ComputeEngineChannelBuilder> { | |||
There was a problem hiding this comment.
This breaks ABI. We can't change this. Ditto for most of the usages in public APIs. AltsChannelBuilder has few enough users it is probably fine. BinderChannelBuilder would be nice to change, but we may not be easily able to. I'm actually surprised it isn't stable, but I guess it was just BinderServerBuilder that was marked stable.
There was a problem hiding this comment.
What about AndroidChannelBuilder? That also looks to be stabilized.
Are we going to use AltsChannelBuilder2 & AndroidChannelBuilder2?
There was a problem hiding this comment.
Undid:
- AndroidChannelBuilder
- BinderChannelBuilder
- ComputeEngineChannelBuilder
- GoogleDefaultChannelBuilder
sergiitk
force-pushed
the
deprecate-fwd-channel-builder
branch
from
121922d to
2c5c69b
Compare
Undo: - AndroidChannelBuilder - BinderChannelBuilder - ComputeEngineChannelBuilder - GoogleDefaultChannelBuilder Add "As of 1.60.0" to `@deprecated` javadoc tag.
larry-safran
approved these changes
Nov 1, 2023
|
Ready for another round |
|
When it's approved, I'll edit |
ejona86
approved these changes
Nov 2, 2023
sergiitk
force-pushed
the
deprecate-fwd-channel-builder
branch
from
2ae064e to
d0ec2d9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate
ForwardingChannelBuilderin favor ofForwardingChannelBuilder2