Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix retries that timeout hanging forever. [ Backport to 1.55.x] #10881

Closed
wants to merge 2 commits into from
Closed

Fix retries that timeout hanging forever. [ Backport to 1.55.x] #10881

wants to merge 2 commits into from

Conversation

larry-safran
Copy link
Contributor

Backport #10855

@larry-safran larry-safran requested a review from temawi February 1, 2024 19:50
temawi
temawi reviewed Feb 1, 2024
View reviewed changes
Copy link
Contributor

@temawi temawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

> Task :grpc-servlet-jakarta:jetty11Test

io.grpc.servlet.jakarta.JettyTransportTest > frameAfterRstStreamShouldNotBreakClientChannel FAILED
    java.lang.IllegalStateException at Response.java:1279

@larry-safran
Fix flaky retry tests (grpc#10887)
340e493 
* Reorder tracing and actually closing listener to eliminate test flakiness
* Use real value rather than mock for flaky test
@larry-safran
Copy link
Contributor Author

Due to problems with tests and rollback from master, removing the PR

@larry-safran larry-safran deleted the backport-retry_timeout-1.55 branch February 27, 2024 00:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@temawi temawi temawi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@larry-safran @temawi