Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix retries that timeout hanging forever. [ Backport to 1.59.x] #10884

Merged
merged 8 commits into from
Feb 6, 2024
Merged

Fix retries that timeout hanging forever. [ Backport to 1.59.x] #10884

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5eeafd9
Fix retries that timeout hanging forever. (#10855)
larry-safran Jan 31, 2024
988b5fa
Fix flaky retry tests (#10887)
larry-safran Feb 5, 2024
19b5bc3
Use future from real scheduling of the command to make sure that desi…
larry-safran Feb 6, 2024
e6440e4
Fix test
larry-safran Feb 6, 2024
fae9ecd
add tolerance for latency fro when soemthing could happen before or a…
larry-safran Feb 6, 2024
1d7690c
fix linelength
larry-safran Feb 6, 2024
4546082
rename variable
larry-safran Feb 6, 2024
a887c46
split line
larry-safran Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion core/src/main/java/io/grpc/internal/RetriableStream.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,10 @@ public void run() {
}
}
if (retryFuture != null) {
retryFuture.cancel(false);
boolean cancelled = retryFuture.cancel(false);
if (cancelled) {
inFlightSubStreams.decrementAndGet();
}
}
if (hedgingFuture != null) {
hedgingFuture.cancel(false);
Expand Down
Loading