Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix retries that timeout hanging forever. [ Backport to 1.61.x] #10886

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

larry-safran
Copy link
Contributor

Backport #10855

@larry-safran larry-safran requested a review from temawi February 1, 2024 19:56
Copy link
Contributor

@temawi temawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, there is a failure:

> Task :grpc-interop-testing:test

io.grpc.testing.integration.RetryTest > statsRecorde_callCancelledBeforeCommit FAILED

* Reorder tracing and actually closing listener to eliminate test flakiness
* Use real value rather than mock for flaky test
@larry-safran larry-safran merged commit 09c8616 into grpc:v1.61.x Feb 5, 2024
14 checks passed
@larry-safran larry-safran deleted the backport-retry_timeout-1.61 branch February 5, 2024 21:44
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants