Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Netty to 4.1.110 and tcnative to 2.0.65 #11444

Merged
merged 6 commits into from
Aug 6, 2024

Conversation

kannanjgithub
Copy link
Contributor

No description provided.

SECURITY.md Outdated
@@ -398,7 +398,8 @@ grpc-netty version | netty-handler version | netty-tcnative-boringssl-static ver
1.56.x | 4.1.87.Final | 2.0.61.Final
1.57.x-1.58.x | 4.1.93.Final | 2.0.61.Final
1.59.x | 4.1.97.Final | 2.0.61.Final
1.60.x- | 4.1.100.Final | 2.0.61.Final
1.60.x-1.65.x | 4.1.100.Final | 2.0.61.Final
1.66.x | 4.1.110.Final | 2.0.65.Final
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this to 1.67. It is too risky to upgrade Netty for this today's release. We won't backport this to the release branch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing the changes to gradle/libs.versions.toml and ShadingTest. I see you reverted the ShadingTest change; that would have been the hint that you were not upgrading Netty within the Gradle build.

@kannanjgithub
Copy link
Contributor Author

This is missing the changes to gradle/libs.versions.toml and ShadingTest. I see you reverted the ShadingTest change; that would have been the hint that you were not upgrading Netty within the Gradle build.

Got it, fixed now.

@kannanjgithub kannanjgithub merged commit 70ae832 into grpc:master Aug 6, 2024
15 checks passed
@kannanjgithub kannanjgithub deleted the nettyupgrade4.1.110 branch August 6, 2024 15:08
dongjoon-hyun added a commit to apache/spark that referenced this pull request Oct 25, 2024
….67.1

### What changes were proposed in this pull request?

This PR aims to upgrade
- `grpcio` and `grpcio-status` to `1.67.0`
- `grpc-java` to `1.67.1`

Please note that `grpc-java` there is no 1.67.0 and 1.68.0 is wrong as announced like the following.

- https://github.com/grpc/grpc-java/releases/tag/v1.67.1
> There was no 1.67.0 release. There was a problem making the release and it went to Maven Central as 1.68.0 instead.

### Why are the changes needed?

To use the latest updated versions as a part of Apache Spark 4.0.0 (February 2025) preparation.
- grpc/grpc-java#11444

### Does this PR introduce _any_ user-facing change?

Although this is a dependency change, it should be backward compatible.

### How was this patch tested?

Pass the CIs.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #48524 from dongjoon-hyun/SPARK-50015.

Lead-authored-by: Dongjoon Hyun <dongjoon@apache.org>
Co-authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants