Use more Bazel module dependencies #11767
Conversation
|
Looks like |
| # CEL Spec may be removed when cncf/xds MODULE is no longer using protobuf 27.x | ||
| bazel_dep(name = "cel-spec", repo_name = "dev_cel", version = "0.15.0") | ||
| bazel_dep(name = "envoy_api", version = "0.0.0-20241214-918efc9") |
There was a problem hiding this comment.
We can't upgrade protobuf beyond 23.1 for a good while yet because of the new protobuf-java major version (we support the newer version, but we need to support the older version too). So we can't use this dependency.
The same problem impacts the xds dependency.
There was a problem hiding this comment.
Then you won't be able to support Bazel 8+ which moved java rules to rules_java which in turn uses a newer Protobuf version and java proto rules to Protobuf itself which is also only available since a recent version.
There was a problem hiding this comment.
I've already tried compiling with Bazel 8 and didn't see any problem. If rules_java requires the newer Protobuf, then yeah, we can't use it.
There was a problem hiding this comment.
How long do you plan to support Protobuf v23 support?
This allows bzlmod version resolution and avoids ODR violations when importing the same dependency multiple times in different modules.