xds: fix the validation code to accept new-style CertificateProviderPluginInstance wherever used #8892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…luginInstance wherever used
|
The fix in this PR verified as reported in #8885 (comment) |
dapengzhang0
reviewed
Feb 7, 2022
Comment on lines
48
to
51
| private static boolean hasValidationProviderInstance(CommonTlsContext commonTlsContext) { | ||
| return (commonTlsContext.hasValidationContext() && commonTlsContext.getValidationContext() | ||
| .hasCaCertificateProviderInstance()) | ||
| || commonTlsContext.hasValidationContextCertificateProviderInstance(); |
There was a problem hiding this comment.
If this method hasValidationProviderInstance is only used once, why not use it inline?
There was a problem hiding this comment.
Similar to other functions defined here e.g. hasIdentityCertificateProviderInstance or hasCertProviderValidationContext. If I inline all functions used only once I'll end up with complex functions (with successive such inlining). In general if it helps in understanding the code I think it is good to have separate, appropriately named functions. The compiler will anyway inline such functions so I don't see the downside.
xds/src/main/java/io/grpc/xds/internal/sds/CommonTlsContextUtil.java
Outdated
Show resolved
Hide resolved
dapengzhang0
approved these changes
Feb 7, 2022
ejona86
added
the
TODO:backport
sanjaypujare
added a commit
to sanjaypujare/grpc-java
that referenced
this pull request
Feb 9, 2022
…luginInstance wherever used (grpc#8892)
sanjaypujare
added a commit
to sanjaypujare/grpc-java
that referenced
this pull request
Feb 9, 2022
…luginInstance wherever used (grpc#8892)
sanjaypujare
added a commit
to sanjaypujare/grpc-java
that referenced
this pull request
Feb 9, 2022
…luginInstance wherever used (grpc#8892)
ejona86
removed
the
TODO:backport
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
CommonTlsContextUtilvalidation functions to accept new-styleCertificateProviderPluginInstancefixes #8885