Revert Provider use in AndroidChannelBuilder and okhttp compileOnly #9039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)" This partly reverts b20ce17 because it is dependent on cda0e9d which is being reverted as it is incompatible with Proguard without configuration (e.g., isAvailable() may not be available and would need a -keep). While the code no longer uses compileOnly, the compatibility still remains, so it would be possible for users to exclude the okhttp dependency if they don't use AndroidChannelBuilder.
This reverts commit cda0e9d. The change was incompatible with Proguard without additional configuration. For example, isAvailable() may not be available and would need a -keep.
|
Also, ironically, when using Proguard |
|
CC @temawi |
YifeiZhuang
approved these changes
Mar 31, 2022
|
#9040 is the fix. We can either rollback now, or just fix-forward. |
|
Closing in favor of fix-forward in #9040 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert #9003 and partly revert #8971. The two commits will be kept separate when merging. There are details in the two commits, but essentially #9003 is incompatible with Proguard and we don't want users to need Proguard configuration.
CC @beatrausch
There's a few options to roll forward, but it'll need to be discussed.