-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auth: Add support for Retryable interface #9102
Conversation
Retryable was added in google-auth-library 1.5.3 to make clear the situations that deserve a retry of the RPC. Bump to that version and swap away from the imprecise IOException heuristic. go/auth-correct-retry Fixes grpc#6808
auth/src/test/java/io/grpc/auth/GoogleAuthLibraryCallCredentialsTest.java
Show resolved
Hide resolved
auth/src/test/java/io/grpc/auth/GoogleAuthLibraryCallCredentialsTest.java
Show resolved
Hide resolved
auth/src/test/java/io/grpc/auth/GoogleAuthLibraryCallCredentialsTest.java
Show resolved
Hide resolved
interop-testing/src/main/java/io/grpc/testing/integration/AbstractInteropTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a comment about a missing test where the Exception is not a RetryableException (but an IOException or not even an IOException).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Passing by - Thanks for fixing! |
Reverted by #9118 |
Retryable was added in google-auth-library 1.5.3 to make clear the
situations that deserve a retry of the RPC. Bump to that version and
swap away from the imprecise IOException heuristic.
go/auth-correct-retry
Fixes #6808
CC @TimurSadykov