Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth: Add support for Retryable interface #9102

Merged
merged 3 commits into from
Apr 26, 2022
Merged

Conversation

ejona86
Copy link
Member

@ejona86 ejona86 commented Apr 22, 2022

Retryable was added in google-auth-library 1.5.3 to make clear the
situations that deserve a retry of the RPC. Bump to that version and
swap away from the imprecise IOException heuristic.
go/auth-correct-retry

Fixes #6808

CC @TimurSadykov

Retryable was added in google-auth-library 1.5.3 to make clear the
situations that deserve a retry of the RPC. Bump to that version and
swap away from the imprecise IOException heuristic.
go/auth-correct-retry

Fixes grpc#6808
@ejona86 ejona86 requested a review from sanjaypujare April 22, 2022 16:29
Copy link
Contributor

@sanjaypujare sanjaypujare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment about a missing test where the Exception is not a RetryableException (but an IOException or not even an IOException).

Copy link
Contributor

@sanjaypujare sanjaypujare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ejona86 ejona86 merged commit 0963f31 into grpc:master Apr 26, 2022
@ejona86 ejona86 deleted the auth-retryable branch April 26, 2022 15:59
@TimurSadykov
Copy link

Passing by - Thanks for fixing!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 26, 2022
@ejona86
Copy link
Member Author

ejona86 commented Sep 9, 2022

Reverted by #9118

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GRPC will keep retrying (until RPC timeout) if a user uses a bad service account key
4 participants