Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

census,observability: suppress message-events in traces when used by observability #9485

Merged
merged 2 commits into from
Aug 26, 2022

Conversation

sanjaypujare
Copy link
Contributor

@sanjaypujare sanjaypujare commented Aug 24, 2022

census: provide a flag addMessageEvents for the client/server tracers to conditionally emit message events
observability: call the tracers with addMessageEvents set to false

@sanjaypujare sanjaypujare requested a review from ejona86 August 24, 2022 05:48
@sanjaypujare
Copy link
Contributor Author

friendly ping @ejona86

Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, those spies are nasty. But I see they were essentially pre-existing.

@sanjaypujare sanjaypujare merged commit 6131a85 into grpc:master Aug 26, 2022
@sanjaypujare sanjaypujare deleted the fix-tracing-bytes branch August 26, 2022 23:40
DNVindhya added a commit to DNVindhya/grpc-java that referenced this pull request Nov 10, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants