compiler: Generate interfaces for services to implement #9688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename TestService to TestServiceAsync Change TestServiceAsync default implementations to be copies of TestServiceImplBase's Change exception type thrown by default implementations of Blocking and Future interaces to UnsupportedOperationException
…nd done for TestServiceGrpc.java.
|
We do not want the client stubs to implement the interfaces; they are final today to prevent mocking. |
ejona86
reviewed
Nov 15, 2022
alts/src/generated/main/grpc/io/grpc/alts/internal/HandshakerServiceGrpc.java
Outdated
Show resolved
Hide resolved
alts/src/generated/main/grpc/io/grpc/alts/internal/HandshakerServiceGrpc.java
Outdated
Show resolved
Hide resolved
* Add a bindService(<service>Async) method * Remove methods from BaseImpl that were defaulted in Interface * Fix indentations.
|
@ejona86 Ready for rereview. |
…instead of using ImplBase.
|
@ejona86 ping |
ejona86
reviewed
Jan 4, 2023
ejona86
reviewed
Jan 5, 2023
alts/src/test/java/io/grpc/alts/HandshakerServiceChannelTest.java
Outdated
Show resolved
Hide resolved
larry-safran
added
the
kokoro:force-run
grpc-kokoro
removed
the
kokoro:force-run
ejona86
reviewed
Feb 14, 2023
alts/src/test/java/io/grpc/alts/HandshakerServiceChannelTest.java
Outdated
Show resolved
Hide resolved
… alts and revert the ignore of venv.
ejona86
approved these changes
Feb 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating Java code from an rpc proto, not only generate the ImplBase and stub methods, but also generate an interface named AsyncService containing the async service methods and have the <service>ImplBase classes implement it in addition to BindableService.
All methods for the interfaces are defined with defaults.
The current logic for the methods in <service>ImplBase will be moved to the default methods ofAsyncService and the methods will be removed from <service>ImplBase.
The bindService logic will be moved into the main Grpc class in a method with the signature:
public static final io.grpc.ServerServiceDefinition bindService(<service>Async serviceImpl)fixes #9320