census: add per call latency metric #9906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since opencensus is deprecated and the repo most likely doesn't accept new PRs I am not sure if you will be able to do that. Just saying... |
census/src/main/java/io/grpc/census/internal/ObservabilityCensusConstants.java
Show resolved
Hide resolved
census/src/main/java/io/grpc/census/internal/ObservabilityCensusConstants.java
Outdated
Show resolved
Hide resolved
sanjaypujare
suggested changes
Feb 24, 2023
…added test for call latency view
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new measure to calculate time taken by gRPC to complete an RPC (i.e
grpc.io/client/api_latency).It also enables corresponding view
GRPC_CLIENT_API_LATENCY_VIEWforgrpc-gcp-observability.Note: New measure and view are defined in
grpc-censustemporarily. This will be moved to opencensus-java repository later.CC @ejona86 @sanjaypujare