Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xds, wrr: randomize the initial deadline in the scheduler #9922

Merged
merged 2 commits into from
Mar 2, 2023
Merged

xds, wrr: randomize the initial deadline in the scheduler #9922

merged 2 commits into from
Mar 2, 2023

Conversation

YifeiZhuang
Copy link
Contributor

@YifeiZhuang YifeiZhuang commented Mar 2, 2023 •
edited
Loading

follow up change #9873

cc. @larry-safran

@YifeiZhuang YifeiZhuang requested a review from ejona86 March 2, 2023 01:40
ejona86
ejona86 reviewed Mar 2, 2023
View reviewed changes
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Larry's comment is important. But other than that, LGTM. I'll let him approve when that fix is made.

xds/src/main/java/io/grpc/xds/WeightedRoundRobinLoadBalancer.java Outdated Show resolved Hide resolved
@YifeiZhuang YifeiZhuang merged commit c367b26 into grpc:master Mar 2, 2023
@YifeiZhuang YifeiZhuang deleted the wrr-random branch March 2, 2023 23:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ejona86 ejona86 ejona86 left review comments

@larry-safran larry-safran larry-safran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YifeiZhuang @ejona86 @larry-safran