Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api:stabilize offloadExecutor. #9931

Merged
merged 2 commits into from
Mar 6, 2023
Merged

Conversation

larry-safran
Copy link
Contributor

Remove experimental annotation from the 3 relevant methods
fixes #6279

@larry-safran larry-safran requested a review from ejona86 March 4, 2023 00:50
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does getOverrideAuthority have to do with offload executor?

@larry-safran
Copy link
Contributor Author

I'm going to blame it on demonic possession. Switched the irrelevant method with a completely different issue number for the correct setOffloadExecutor

@larry-safran larry-safran requested a review from ejona86 March 6, 2023 18:43
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a likely reason :)

@larry-safran larry-safran merged commit 7aa5598 into grpc:master Mar 6, 2023
@larry-safran larry-safran deleted the is-6279 branch March 21, 2023 17:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

offloadExecutor is experimental API
2 participants