gcp-observability: Update logging fields for GA and use custom BatchingSettings #9959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
); added custom batch setting for LoggingOptions
…a default timeout of 6 seconds
ejona86
approved these changes
Mar 16, 2023
gcp-observability/src/main/java/io/grpc/gcp/observability/logging/GcpLogSink.java
Outdated
Show resolved
Hide resolved
larry-safran
pushed a commit
to larry-safran/grpc-java
that referenced
this pull request
Mar 20, 2023
…ngSettings (grpc#9959) This commit updates the following in gcp observability logging schema * `payload.status_code` will be of type `google.rpc.Code` instead of `uint32`. * names in enum `Address.TYPE` Use custom batching settings for [LoggingOptions](https://javadoc.io/doc/com.google.cloud/google-cloud-logging/latest/com/google/cloud/logging/LoggingOptions.html) Note: Upgraded `com.google.cloud:google-cloud-logging` from `3.6.1` to `3.14.5`.
larry-safran
pushed a commit
to larry-safran/grpc-java
that referenced
this pull request
Mar 20, 2023
…ngSettings (grpc#9959) This commit updates the following in gcp observability logging schema * `payload.status_code` will be of type `google.rpc.Code` instead of `uint32`. * names in enum `Address.TYPE` Use custom batching settings for [LoggingOptions](https://javadoc.io/doc/com.google.cloud/google-cloud-logging/latest/com/google/cloud/logging/LoggingOptions.html) Note: Upgraded `com.google.cloud:google-cloud-logging` from `3.6.1` to `3.14.5`.
DNVindhya
added a commit
to DNVindhya/grpc-java
that referenced
this pull request
Mar 21, 2023
…ngSettings (grpc#9959) This commit updates the following in gcp observability logging schema * `payload.status_code` will be of type `google.rpc.Code` instead of `uint32`. * names in enum `Address.TYPE` Use custom batching settings for [LoggingOptions](https://javadoc.io/doc/com.google.cloud/google-cloud-logging/latest/com/google/cloud/logging/LoggingOptions.html) Note: Upgraded `com.google.cloud:google-cloud-logging` from `3.6.1` to `3.14.5`.
ejona86
pushed a commit
that referenced
this pull request
Mar 21, 2023
…ngSettings (#9959) This commit updates the following in gcp observability logging schema * `payload.status_code` will be of type `google.rpc.Code` instead of `uint32`. * names in enum `Address.TYPE` Use custom batching settings for [LoggingOptions](https://javadoc.io/doc/com.google.cloud/google-cloud-logging/latest/com/google/cloud/logging/LoggingOptions.html) Note: Upgraded `com.google.cloud:google-cloud-logging` from `3.6.1` to `3.14.5`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the following in gcp observability logging schema
payload.status_codewill be of typegoogle.rpc.Codeinstead ofuint32.Address.TYPEUse custom batching settings for LoggingOptions
Note: Upgraded
com.google.cloud:google-cloud-loggingfrom3.6.1to3.14.5.CC @ejona86 @sanjaypujare