gcp-observability, census: add trace information to logs #9963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
approved these changes
Mar 20, 2023
gcp-observability/src/main/java/io/grpc/gcp/observability/logging/TraceLoggingHelper.java
Show resolved
Hide resolved
gcp-observability/src/main/java/io/grpc/gcp/observability/interceptors/LogHelper.java
Outdated
Show resolved
Hide resolved
ejona86
added
the
TODO:release blocker
ejona86
approved these changes
Mar 20, 2023
|
@DNVindhya, your PR descriptions have a lot of really good information in them. It would be helpful to include that information in the commit message, so it is available in the commit history. You can just write it once in the git commit, and github will automatically copy it into the PR. |
ejona86
added
TODO:backport
DNVindhya
added a commit
to DNVindhya/grpc-java
that referenced
this pull request
Mar 21, 2023
This commit adds trace information (TraceId, SpanId and TraceSampled) fields to LogEntry, when both logging and tracing are enabled in gcp-observability. For server-side logs, span information was readily available using Span.getContext() propagated via `io.grpc.Context`. Similar approach is not feasible for client-side architecture. Client SpanContext which has all the information required to be added to logs is propagated to the logging interceptor via `io.grpc.CallOptions`.
ejona86
pushed a commit
that referenced
this pull request
Mar 21, 2023
This commit adds trace information (TraceId, SpanId and TraceSampled) fields to LogEntry, when both logging and tracing are enabled in gcp-observability. For server-side logs, span information was readily available using Span.getContext() propagated via `io.grpc.Context`. Similar approach is not feasible for client-side architecture. Client SpanContext which has all the information required to be added to logs is propagated to the logging interceptor via `io.grpc.CallOptions`.
ejona86
removed
the
TODO:backport
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds trace information (TraceId, SpanId and TraceSampled) fields to LogEntry, when both logging and tracing are enabled in gcp-observability.
For server-side logs, span information was readily available using Span.getContext() propagated via
io.grpc.Context. Similar approach is not feasible for client-side architecture.Client SpanContext which has all the information required to be added to logs is propagated to the logging interceptor via
io.grpc.CallOptions.CC @ejona86 @sanjaypujare